Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing vibrancy breaking change #40893

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

codebytere
Copy link
Member

Description of Change

Closes #40799.

Adds missing breaking vibrancy change forced in #38891

Checklist

Release Notes

Notes: none

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. labels Jan 5, 2024
@codebytere codebytere requested a review from a team as a code owner January 5, 2024 13:19
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 5, 2024
@codebytere codebytere mentioned this pull request Jan 5, 2024
3 tasks
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs: lgtm

Copy link

@electron-docs-reviewer electron-docs-reviewer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of the Electron Docs Team

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jan 6, 2024
@VerteDinde VerteDinde merged commit 3a22fd3 into main Jan 7, 2024
27 checks passed
@VerteDinde VerteDinde deleted the breaking-changes-vibrancy branch January 7, 2024 21:56
Copy link

release-clerk bot commented Jan 7, 2024

No Release Notes

@trop
Copy link
Contributor

trop bot commented Jan 7, 2024

I have automatically backported this PR to "27-x-y", please check out #40905

@trop trop bot added in-flight/27-x-y and removed target/27-x-y PR should also be added to the "27-x-y" branch. labels Jan 7, 2024
@trop
Copy link
Contributor

trop bot commented Jan 7, 2024

I have automatically backported this PR to "28-x-y", please check out #40906

@trop
Copy link
Contributor

trop bot commented Jan 7, 2024

I have automatically backported this PR to "29-x-y", please check out #40907

@trop trop bot added in-flight/28-x-y in-flight/29-x-y merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. labels Jan 7, 2024
@trop trop bot added merged/28-x-y PR was merged to the "28-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. and removed in-flight/27-x-y in-flight/28-x-y in-flight/29-x-y labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Broken Vibrancy
5 participants