Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enforce consistent Markdown style for strong and emphasis #37787

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

dsanders11
Copy link
Member

Description of Change

Follow-up to #36540 which enables the rules enforcing consistent style for strong and emphasis. In our docs that means ** and _, respectively, as those are the dominant styles.

Also updated the line endings for .markdownlint.json as it was CRLF for some reason.

Checklist

  • PR description included and stakeholders cc'd

Release Notes

Notes: none

@dsanders11 dsanders11 added semver/none target/24-x-y PR should also be added to the "24-x-y" branch. labels Mar 31, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 31, 2023
Comment on lines +663 to +664
"foobar.com", "\*foobar.com", "\*.foobar.com", "\*foobar.com:99",
"https://x.\*.y.com:99"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fix a rendering issue on the docs website since these asterisks were being interpreted as meaning emphasis.

Screenshot 2023-03-31 at 3 10 21 PM

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 1, 2023
@codebytere codebytere merged commit 4415b76 into electron:main Apr 3, 2023
@release-clerk
Copy link

release-clerk bot commented Apr 3, 2023

No Release Notes

@trop
Copy link
Contributor

trop bot commented Apr 3, 2023

I was unable to backport this PR to "24-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/24-x-y and removed target/24-x-y PR should also be added to the "24-x-y" branch. labels Apr 3, 2023
@dsanders11 dsanders11 deleted the enable-markdownlint-rules branch April 3, 2023 11:30
@trop
Copy link
Contributor

trop bot commented Apr 5, 2023

@dsanders11 has manually backported this PR to "24-x-y", please check out #37845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/24-x-y PR was merged to the "24-x-y" branch semver/none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants