fix: incorrect Content-Disposition serialization #31669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Can you also update the test added in #25961 to also reflect this change ? Thanks! |
|
@deepak1556 done, thanks! |
deepak1556
approved these changes
Nov 2, 2021
zcbenz
approved these changes
Nov 3, 2021
jkleinsc
approved these changes
Nov 3, 2021
|
Release Notes Persisted
|
This was referenced Nov 3, 2021
|
I have automatically backported this PR to "13-x-y", please check out #31691 |
|
I have automatically backported this PR to "14-x-y", please check out #31692 |
|
I have automatically backported this PR to "15-x-y", please check out #31693 |
|
I have automatically backported this PR to "16-x-y", please check out #31694 |
t57ser
pushed a commit
to t57ser/electron
that referenced
this pull request
Jan 25, 2022
* fix: incorrect Content-Disposition serialization * test: fixup test
This was referenced Jul 13, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #31662.
Refs #25961.
Fixes an issue where
Content-Dispositionfilenames would be incorrectly truncated at the first comma for filename attachments which contained one. This was happening becuase the filename in the parsenet::HttpContentDispositionheader was not being correctly wrapped in double quotes, thereby breaking serialization.Tested with the repro provided in the above linked issue:
Before
After
Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where
Content-Dispositionfilenames would be incorrectly truncated at the first comma for a filename attachment which contained one.