Allow "released callback" errors to be traced to remote calls #3103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very difficult to understand and trace
Calling a callback of released renderer view
errors, which are caused by passing functions toremote
and then releasing the window.These changes make it easy to debug and fix these by changing the "ID" used to track the functions. The callbacks-registry uses
(new Error).stack
to identify the file and line number where the function was passed to a remote call, and includes that in the ID.index.html:
The new exceptions look like this: