Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: uniformize tutorial titles #30527

Merged
merged 1 commit into from
Aug 16, 2021
Merged

docs: uniformize tutorial titles #30527

merged 1 commit into from
Aug 16, 2021

Conversation

erickzhao
Copy link
Member

Description of Change

Tidies up the doc names within the /tutorial/ folder.

  • Title case enforced for titles (as per style guide)
  • Made some titles more concise (e.g. Using Native Node Modules becomes Native Node Modules)
  • Made platform-specific titles consistent

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 13, 2021
@erickzhao erickzhao requested a review from a team August 13, 2021 22:28
malept
malept approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I've ever seen the word "uniformize" until now 😅

:shipit:

wcampbell40
wcampbell40 reviewed Aug 13, 2021
View reviewed changes
Copy link

@wcampbell40 wcampbell40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and uniform.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 14, 2021
@codebytere codebytere merged commit 740dcc5 into electron:main Aug 16, 2021
@release-clerk
Copy link

release-clerk bot commented Aug 16, 2021

No Release Notes

This was referenced Aug 16, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 16, 2021

I have automatically backported this PR to "14-x-y", please check out #30545

@trop
Copy link
Contributor

trop bot commented Aug 16, 2021

I have automatically backported this PR to "13-x-y", please check out #30546

@trop trop bot removed target/14-x-y labels Aug 16, 2021
@trop
Copy link
Contributor

trop bot commented Aug 16, 2021

I have automatically backported this PR to "15-x-y", please check out #30547

miniak pushed a commit that referenced this pull request Aug 18, 2021
@erickzhao @miniak
docs: uniformize tutorial titles (#30527)
446a1eb
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@erickzhao @BlackHole1
docs: uniformize tutorial titles (electron#30527)
d82e57c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcampbell40 wcampbell40 wcampbell40 left review comments

@codebytere codebytere codebytere approved these changes

@malept malept malept approved these changes

Assignees
No one assigned
Labels
documentation 📓 semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erickzhao @malept @codebytere @wcampbell40