Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove the vendor directory #28883

Merged
merged 1 commit into from
Apr 28, 2021
Merged

build: remove the vendor directory #28883

merged 1 commit into from
Apr 28, 2021

Conversation

MarshallOfSound
Copy link
Member

The vendor directory is a remnant of times long since gone when we had brightray and libchromiumcontent (never forget). It is currently the hope to a single header file that afaics we do not need anymore and randomly pyyaml gets cloned there but that is easily movable.

This commit removes all references to the vendor directory from scripts, docs, helpers, etc. and removes the directory itself.

Notes: none

The `vendor` directory is a remnant of times long since gone when we had
brightray and libchromiumcontent (never forget).  It is currently the
hope to a single header file that afaics we do not need anymore and
randomly pyyaml gets cloned there but that is easily movable.

This commit removes all references to the vendor directory from scripts,
docs, helpers, etc. and removes the directory itself.
@MarshallOfSound
Copy link
Member Author

Not a clean backport and there's no benefit to backporting this so just gonna leave it in master

@MarshallOfSound MarshallOfSound merged commit 3879e9e into master Apr 28, 2021
@MarshallOfSound MarshallOfSound deleted the remove-vendor branch April 28, 2021 07:38
@release-clerk
Copy link

release-clerk bot commented Apr 28, 2021

No Release Notes

@codebytere
Copy link
Member

/trop run backport-to 13-x-y,12-x-y,11-x-y

@trop
Copy link
Contributor

trop bot commented Apr 28, 2021

The backport process for this PR has been manually initiated - sending your PR to 13-x-y!

@trop
Copy link
Contributor

trop bot commented Apr 28, 2021

The backport process for this PR has been manually initiated - sending your PR to 12-x-y!

@trop
Copy link
Contributor

trop bot commented Apr 28, 2021

The backport process for this PR has been manually initiated - sending your PR to 11-x-y!

@trop
Copy link
Contributor

trop bot commented Apr 28, 2021

I was unable to backport this PR to "13-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 28, 2021

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 28, 2021

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants