More infos on did-get-redirect-request event #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekuz0r
force-pushed
the
enhanced-redirect-event
branch
from
67a8980 to
d82f886
Compare
| v8::Locker locker(isolate()); | ||
| v8::HandleScope handle_scope(isolate()); | ||
|
|
||
| v8::Local<v8::Value> response_headers = mate::ConvertToV8(isolate(), |
There was a problem hiding this comment.
You don't have to do the conversion manually, you can just call Emit(..., details.headers.get()) for automatic conversion, and the Locker and HandleScope calls can also be removed since Emit has taken care of it.
The DidGetResourceResponseStart needs to do the same change too.
nekuz0r
force-pushed
the
enhanced-redirect-event
branch
from
d82f886 to
2b74326
Compare
…-redirect-request event.
nekuz0r
force-pushed
the
enhanced-redirect-event
branch
from
2b74326 to
4771031
Compare
|
@zcbenz Updated |
|
👍 |
zcbenz
added a commit
that referenced
this pull request
Sep 21, 2015
More infos on did-get-redirect-request event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add http_response_code, method, referrer, response_headers to did-get-redirect-request event.