-
Notifications
You must be signed in to change notification settings - Fork 15.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ipcRenderer.invoke() #18449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some thoughts on multiple handlers and error proxying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 💯 mostly just typing things commented
Release Notes Persisted
|
Description of Change
This adds a new IPC primitive,
ipcRenderer.invoke()
. This models a request/response paradigm, similar toipcRenderer.sendSync
but asynchronous.Checklist
npm test
passesRelease Notes
Notes: Added
ipcRenderer.invoke()
andipcMain.handle()
for asynchronous request/response-style IPC.