Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ipcRenderer.invoke() #18449

Merged
merged 7 commits into from
May 31, 2019
Merged

feat: add ipcRenderer.invoke() #18449

merged 7 commits into from
May 31, 2019

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented May 24, 2019

Description of Change

This adds a new IPC primitive, ipcRenderer.invoke(). This models a request/response paradigm, similar to ipcRenderer.sendSync but asynchronous.

Checklist

Release Notes

Notes: Added ipcRenderer.invoke() and ipcMain.handle() for asynchronous request/response-style IPC.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 24, 2019
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some thoughts on multiple handlers and error proxying

docs/api/ipc-renderer.md Outdated Show resolved Hide resolved
atom/renderer/api/atom_api_renderer_ipc.cc Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 25, 2019
@nornagon nornagon requested a review from MarshallOfSound May 28, 2019 23:40
docs/api/ipc-main.md Outdated Show resolved Hide resolved
docs/api/ipc-main.md Outdated Show resolved Hide resolved
docs/api/ipc-main.md Outdated Show resolved Hide resolved
docs/api/ipc-main.md Outdated Show resolved Hide resolved
docs/api/ipc-main.md Show resolved Hide resolved
lib/browser/api/ipc-main.ts Outdated Show resolved Hide resolved
lib/browser/api/ipc-main.ts Outdated Show resolved Hide resolved
lib/browser/api/web-contents.js Outdated Show resolved Hide resolved
lib/browser/api/web-contents.js Outdated Show resolved Hide resolved
docs/api/structures/ipc-main-event.md Outdated Show resolved Hide resolved
lib/browser/api/web-contents.js Outdated Show resolved Hide resolved
lib/renderer/api/ipc-renderer.js Show resolved Hide resolved
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 💯 mostly just typing things commented

lib/browser/api/ipc-main.ts Show resolved Hide resolved
lib/browser/api/web-contents.js Outdated Show resolved Hide resolved
@nornagon nornagon merged commit c436997 into master May 31, 2019
@release-clerk
Copy link

release-clerk bot commented May 31, 2019

Release Notes Persisted

Added ipcRenderer.invoke() and ipcMain.handle() for asynchronous request/response-style IPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants