Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly parse default_app path on windows #18102

Merged
merged 1 commit into from
May 3, 2019
Merged

fix: correctly parse default_app path on windows #18102

merged 1 commit into from
May 3, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 1, 2019

Backport of #18086

See that PR for details.

Notes: no-notes

@trop trop bot mentioned this pull request May 1, 2019
Merged
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 1, 2019
@trop trop bot added 6-0-x backport This is a backport PR labels May 1, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 1, 2019
@jkleinsc
Copy link
Member

jkleinsc commented May 3, 2019

Merging with know windows 32-bit CI failure unrelated to this PR.

@jkleinsc jkleinsc merged commit a431f1a into 6-0-x May 3, 2019
@release-clerk
Copy link

release-clerk bot commented May 3, 2019

No Release Notes

@jkleinsc jkleinsc deleted the trop/6-0-x-bp-fix-correctly-parse-default_app-path-on-windows-1556740823059 branch May 3, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
6-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkleinsc @codebytere @MarshallOfSound