fix: correctly parse default_app path on windows #18086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
reviewed
May 1, 2019
There was a problem hiding this comment.
what about doing a similar check to how we enforce preload scripts to be from the appPath?
https://github.com/electron/electron/blob/master/lib/browser/rpc-server.js#L514
|
@MarshallOfSound maybe related to #18092 |
|
@miniak The issue here isn't asar or realpath. We can't call |
codebytere
approved these changes
May 1, 2019
|
No Release Notes |
|
I have automatically backported this PR to "6-0-x", please check out #18102 |
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this on my Windows machine while verifying the
6.0.0-beta.1release. On windows,pathnamelooks like/c:/a/b/c(that preceding/breaks things). No notes as it's adefault_appUI change, app devs don't need to know.This is the bug -->
Notes: no-notes