Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clean up the native module tutorial #17624

Merged
merged 1 commit into from
Apr 24, 2019
Merged

docs: clean up the native module tutorial #17624

merged 1 commit into from
Apr 24, 2019

Conversation

malept
Copy link
Member

@malept malept commented Mar 30, 2019 •
edited
Loading

Description of Change

  • Adds the error message that you'd get if you didn't rebuild modules, for SEO purposes
  • Moves electron-rebuild to the first spot in the list of ways to rebuild modules
  • Updates links
  • Grammar cleanup

CC: @electron/wg-docs-tools since I don't seem to be able to assign reviewers.

Checklist

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Mar 30, 2019
@MarshallOfSound MarshallOfSound requested a review from a team April 1, 2019 15:04
vhashimotoo
vhashimotoo approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@vhashimotoo vhashimotoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@codebytere codebytere merged commit aed0b1e into electron:master Apr 24, 2019
@release-clerk
Copy link

release-clerk bot commented Apr 24, 2019

No Release Notes

@trop
Copy link
Contributor

trop bot commented Apr 24, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Apr 24, 2019
Merged
@trop trop bot removed the target/5-0-x label Apr 24, 2019
@trop
Copy link
Contributor

trop bot commented Apr 24, 2019

I have automatically backported this PR to "6-0-x", please check out #17951

@malept malept deleted the update-native-module-docs branch April 24, 2019 17:42
@trop trop bot added the merged/6-0-x label Apr 24, 2019
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@malept @kiku-jw
docs: clean up the native module tutorial (electron#17624)
4c4da37
@codebytere
Copy link
Member

@malept would you mind backporting this to 5-0-x?

@malept
Copy link
Member Author

malept commented Aug 5, 2019

Sure, I can give it a shot.

malept added a commit to malept/electron that referenced this pull request Aug 5, 2019
@malept
docs: clean up the native module tutorial
a99c96e 
This is a backport of electron#17624 for 5-0-x.
@malept malept mentioned this pull request Aug 5, 2019
Merged
4 tasks
@trop
Copy link
Contributor

trop bot commented Aug 5, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #19629

codebytere pushed a commit that referenced this pull request Aug 5, 2019
@malept @codebytere
docs: clean up the native module tutorial (#19629)
21aaf67 
This is a backport of #17624 for 5-0-x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhashimotoo vhashimotoo vhashimotoo approved these changes

@codebytere codebytere codebytere approved these changes

@Kilian Kilian Kilian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@malept @codebytere @Kilian @vhashimotoo