protocol: adding error job to log error with custom protocols #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -105,6 +105,14 @@ class CustomProtocolRequestJob : public AdapterRequestJob { | |||
| base::Bind(&AdapterRequestJob::CreateFileJobAndStart, | |||
| GetWeakPtr(), path)); | |||
| return; | |||
| } else if (name == "RequestErrorJob") { | |||
| int error; | |||
There was a problem hiding this comment.
We should have a default error here in case user didn't specify one.
There was a problem hiding this comment.
Ah yeah, but what would be the default ?
There was a problem hiding this comment.
Maybe net::ERR_NOT_IMPLEMENTED.
There was a problem hiding this comment.
or net::ERR_TIMED_OUT ? will add the default value to the docs..
There was a problem hiding this comment.
net::ERR_TIMED_OUT makes it look like a connection error.
There was a problem hiding this comment.
cool, added net::ERR_NOT_IMPLEMENTED as default.
deepak1556
force-pushed
the
protocol_error_patch
branch
from
40a0e58 to
24bcd3b
Compare
|
Thanks! |
zcbenz
added a commit
that referenced
this pull request
May 11, 2015
protocol: adding error job to log error with custom protocols
|
Thanks a lot! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1189