Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct windowMenu role on MacOS #15930

Merged
merged 1 commit into from
Dec 3, 2018
Merged

fix: correct windowMenu role on MacOS #15930

merged 1 commit into from
Dec 3, 2018

Conversation

codebytere
Copy link
Member

Description of Change

Resolves #15912.

Updates windowMenu MenuItem role to more accurately reflect the default window menu on MacOS. Also updates the default app to use this role.

/cc @sindresorhus @BinaryMuse

Checklist

Release Notes

Notes: correct windowMenu MenuItem role on MacOS

@codebytere codebytere requested review from a team December 3, 2018 16:34
@MarshallOfSound
Copy link
Member

Is this technically semver/major?

@codebytere codebytere changed the title fix: make windowMenu role correct on MacOS fix: correct windowMenu role on MacOS Dec 3, 2018
@codebytere
Copy link
Member Author

codebytere commented Dec 3, 2018 •
edited
Loading

Maybe? i'd say fix is arguable since it's incorrect for MacOS as it currently stands

@BinaryMuse
Copy link
Contributor

Hm, I could see the argument each way. Even though the behavior is technically incorrect, if fixing it could potentially cause apps or behavior to change in a non-backward-compat way, I'd argue that it's probably better a semver/major change too.

BinaryMuse
BinaryMuse approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@BinaryMuse BinaryMuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super familiar with this but it seems okay to me

@codebytere codebytere added the semver/major incompatible API changes label Dec 3, 2018
@codebytere codebytere merged commit a1a431e into master Dec 3, 2018
@release-clerk
Copy link

release-clerk bot commented Dec 3, 2018

Release Notes Persisted

correct windowMenu MenuItem role on MacOS

@codebytere codebytere deleted the fix-macos-windowmenu branch December 3, 2018 19:52
@miniak miniak mentioned this pull request Jan 14, 2019
Merged
5 tasks
@sindresorhus sindresorhus mentioned this pull request Feb 20, 2019
Merged
trop-bot pushed a commit to trop-bot/electron that referenced this pull request Feb 25, 2019
@sindresorhus @electron-bot
docs: fix MenuItem windowMenu role description
83c7ac8 
It was changed in electron#15930
codebytere pushed a commit that referenced this pull request Feb 25, 2019
@sindresorhus @codebytere
docs: fix MenuItem windowMenu role description (#17065)
df5305d 
It was changed in #15930
trop-bot pushed a commit to trop-bot/electron that referenced this pull request Feb 25, 2019
@sindresorhus @electron-bot
docs: fix MenuItem windowMenu role description
142bca8 
It was changed in electron#15930
codebytere pushed a commit that referenced this pull request Feb 27, 2019
@trop @codebytere
docs: fix MenuItem windowMenu role description (#17118)
119382b 
It was changed in #15930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinaryMuse BinaryMuse BinaryMuse approved these changes

Assignees
No one assigned
Labels
semver/major incompatible API changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @MarshallOfSound @BinaryMuse