Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add note about win_delay_load_hook #15766

Merged
merged 2 commits into from
Nov 20, 2018
Merged

docs: add note about win_delay_load_hook #15766

merged 2 commits into from
Nov 20, 2018

Conversation

nornagon
Copy link
Member

Description of Change

Ref #15436

Release Notes

Notes: 'win_delay_load_hook': 'true' is now required when building native modules on Windows

@nornagon nornagon requested a review from a team November 19, 2018 21:02
BinaryMuse
BinaryMuse approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@BinaryMuse BinaryMuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo, otherwise LGTM

@nornagon
Update docs/tutorial/using-native-node-modules.md
8173385 
Co-Authored-By: nornagon <nornagon@nornagon.net>
@nornagon
Copy link
Member Author

Appveyor is flake, merging

@nornagon nornagon merged commit 08b56b7 into master Nov 20, 2018
@release-clerk
Copy link

release-clerk bot commented Nov 20, 2018 •
edited by nornagon
Loading

Release Notes Persisted

document that 'win_delay_load_hook': 'true' is now required when building native modules on Windows

@nornagon nornagon deleted the docs/win-delay-load-hook branch November 20, 2018 00:13
@trop
Copy link
Contributor

trop bot commented Nov 20, 2018

I have automatically backported this PR to "4-0-x", please check out #15771

@trop trop bot mentioned this pull request Nov 20, 2018
Merged
bcpete pushed a commit to bcpete/electron that referenced this pull request Apr 18, 2019
@nornagon @bcpete
docs: add note about win_delay_load_hook (electron#15766)
b967ca2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinaryMuse BinaryMuse BinaryMuse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nornagon @BinaryMuse