Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove legacy helpers (Electron Helper EH/NP) #14436

Merged
merged 1 commit into from
Sep 4, 2018
Merged

build: remove legacy helpers (Electron Helper EH/NP) #14436

merged 1 commit into from
Sep 4, 2018

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Sep 3, 2018 •
edited
Loading

Description of Change

Electron Helper EH/NP is not used anymore. Chrome is also not shipping these separate helpers anymore (since NPAPI plugin support was removed)

https://bugs.chromium.org/p/chromium/issues/detail?id=520680

Google Chrome Helper EH.app is the "executable helper" which is only used by NPAPI. This needs to be removed as it is no longer used.

Checklist
  • PR description included and stakeholders cc'd
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines
Release Notes

Notes: Removed legacy helpers (Electron Helper EH/NP).

@miniak miniak requested a review from a team September 3, 2018 16:40
@miniak miniak force-pushed the miniak/remove-legacy-helpers branch from 8a3e7cd to 68a9695 Compare September 3, 2018 16:43
@miniak miniak requested a review from a team September 3, 2018 16:43
@miniak miniak self-assigned this Sep 3, 2018
@miniak miniak changed the title feat: remove legacy helpers (Electron Helper EH/NP) build: remove legacy helpers (Electron Helper EH/NP) Sep 3, 2018
@miniak miniak requested a review from deepak1556 September 3, 2018 17:41
deepak1556
deepak1556 approved these changes Sep 3, 2018
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍there are also other tools/ that will be rendered unused after #14097 , we should probably clean them all together. But it makes sense to clean this one separately, as its not related to GYP -> GN migration.

@miniak
Copy link
Contributor Author

miniak commented Sep 3, 2018

@deepak1556 it would make sense to do this for 3.0 as well, but I guess it's technically a breaking change.

@alexeykuzmin
Copy link
Contributor

@deepak1556
You're absolutely right.
Moving to GN is a great opportunity for us to clean all obsolete tools and scripts.
But the PR in question intentionally doesn't try to remove everything to be easier to be reviewed.

ckerr
ckerr approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ckerr ckerr merged commit e8782f2 into master Sep 4, 2018
@release-clerk
Copy link

release-clerk bot commented Sep 4, 2018

Release Notes Persisted

Removed legacy helpers (Electron Helper EH/NP).

@ckerr ckerr deleted the miniak/remove-legacy-helpers branch September 4, 2018 02:37
@deepak1556
Copy link
Member

@miniak I would be onboard for backporting this to 3.x, technically this isn't a breaking change as its an unused binary, i don't see a reason for users to depend on it.

@miniak
Copy link
Contributor Author

miniak commented Sep 4, 2018

@deepak1556 there might be some tools packaging Electron apps expecting those helpers to be present though.

@miniak
Copy link
Contributor Author

miniak commented Sep 4, 2018

/trop run backport-to 3-0-x

@MarshallOfSound
Copy link
Member

@miniak You have to be on a list to run trop commands

@MarshallOfSound
Copy link
Member

/trop run backport-to 3-0-x

@trop
Copy link
Contributor

trop bot commented Sep 4, 2018

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "3-0-x" here we go! :D

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Sep 4, 2018 •
edited
Loading

Actually wait, we probably shouldn't backport this. Will result in peoples packager scripts breaking

@trop trop bot mentioned this pull request Sep 4, 2018
Closed
@trop
Copy link
Contributor

trop bot commented Sep 4, 2018

We have automatically backported this PR to "3-0-x", please check out #14452

@trop trop bot added the merged/3-0-x label Sep 4, 2018
@malept malept mentioned this pull request Oct 1, 2018
Merged
5 tasks
@audionerd audionerd mentioned this pull request Oct 23, 2018
Closed
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@ckerr ckerr ckerr approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

@codebytere codebytere Awaiting requested review from codebytere

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miniak @alexeykuzmin @deepak1556 @MarshallOfSound @ckerr