Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize ICU in Node mode #1019

Merged
merged 3 commits into from
Jan 17, 2015
Merged

Initialize ICU in Node mode #1019

merged 3 commits into from
Jan 17, 2015

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Jan 17, 2015

In atom-shell we are using V8 that compiled with ICU support, so we should initialize ICU when running as Node, otherwise things like String::localeCompare will crash in scripts ran by child_process.fork.

Fix #979.
Fix #961.

zcbenz added a commit that referenced this pull request Jan 17, 2015
@zcbenz
Merge pull request #1019 from atom/locale-in-node
c59bd82 
Initialize ICU in Node mode
@zcbenz zcbenz merged commit c59bd82 into master Jan 17, 2015
@zcbenz zcbenz deleted the locale-in-node branch January 17, 2015 01:08
@springmeyer springmeyer mentioned this pull request Mar 17, 2016
Open
This was referenced Aug 31, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

String.localeCompare crashes in Node mode illegal access in child process
1 participant
@zcbenz