-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootloader additions #390
Merged
stephenhensley
merged 100 commits into
electro-smith:master
from
CorvusPrudens:dfu_compatible
Sep 28, 2021
Merged
Bootloader additions #390
stephenhensley
merged 100 commits into
electro-smith:master
from
CorvusPrudens:dfu_compatible
Sep 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiled size on the example I used increased by 536 bytes, from 44,028 to 44,564. Like i2c, this module takes a config struct for configuration. It may not align with other classes in `daisy_seed.h`. I didn't test the CMake build, but it should work with my single change to the cmakelists file.
The `dsy_gpio_pin` array of `qspi_impl` avoids large switch statements in the hal pin initialization.
Created SdramHandler class. Updated all of those typedef structs to enum classes. Renamed and slightly tweaked functions to work within class. Updated seed board support to use cpp-ified sdram
Sdram init needed to wait until after then config The hal map needed to be included as a C extern. I udpated hal_map to be cpp in my GPIO pr, so that wont last long
I also restored the default linker back to its original state.
cpp tag for code syntax highlighting.
This commit _may_ add a bit of unnecessary delay to the startup. If that's a problem to your use case and you'd like pre-initialized SDRAM, look into adjusting the length of the delay loop in sdram_startup.h
stephenhensley
requested changes
Sep 22, 2021
stephenhensley
requested changes
Sep 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last few things I made notes about as well as:
- Adding memory-aware system init should be added to the DaisyPatchSM
stephenhensley
requested changes
Sep 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final changes, most of which are just cleaning up the change log, and removing old comments.
stephenhensley
approved these changes
Sep 28, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes SDRAM startup, as well as QSPI and bootloader changes. The bootloader procedure is documented (and should be made available quite soon).