Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Views] Unify delete data view modal #206466

Merged
merged 4 commits into from
Jan 14, 2025
Merged

[Data Views] Unify delete data view modal #206466

merged 4 commits into from
Jan 14, 2025

Conversation

kowalczyk-krzysztof
Copy link
Member

Summary

This PR makes delete data view modal both to look the same.
Closes: #204174

@kowalczyk-krzysztof kowalczyk-krzysztof added Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jan 13, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Jan 13, 2025
@kowalczyk-krzysztof kowalczyk-krzysztof requested a review from a team as a code owner January 13, 2025 15:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

jughosta
jughosta reviewed Jan 14, 2025
View reviewed changes
...gins/shared/data_view_management/public/components/edit_index_pattern/edit_index_pattern.tsx Outdated
[indexPattern as RemoveDataViewProps],
deleteModalMsg(
[indexPattern as RemoveDataViewProps],
Boolean(indexPattern.namespaces)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kowalczyk-krzysztof,

Thanks for unifying the modals!

Can you please check why Spaces count is not correct when deleting from a data view page?
Jan-14-2025 10-23-42

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jughosta
Thanks for catching that. I was passing down wrong variable, fixed.

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #30 / Serverless Observability - Deployment-agnostic API integration tests observability AI Assistant When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings "after all" hook in "When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings"
  • [job] [logs] FTR Configs #30 / Serverless Observability - Deployment-agnostic API integration tests observability AI Assistant When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings "before all" hook in "When there are knowledge base entries (from 8.15 or earlier) that does not contain semantic_text embeddings"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewManagement 137.6KB 137.0KB -600.0B

History

cc @kowalczyk-krzysztof

jughosta
jughosta approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kowalczyk-krzysztof kowalczyk-krzysztof merged commit c964c58 into elastic:main Jan 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jughosta jughosta jughosta approved these changes

Assignees

@kowalczyk-krzysztof kowalczyk-krzysztof

Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data Views] Unify delete data view experience
4 participants
@kowalczyk-krzysztof @elasticmachine @jughosta @kibanamachine