Propagate DocValueFormat to all terms aggs. #17646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
>non-issue
review
:Analytics/Aggregations
|
LGTM |
TL;DR This commit should not have any impact on terms aggs, it will just make supporting ipv6 easier. Currently only the numeric terms aggs propagate the DocValueFormat instance since we use numerics to represent also dates or ip addresses. Since string terms aggs are only used for text/keyword/string fields, they do not use the format and just call toUt8String(). However when we support ipv6, ip addresses as well will be encoded in sorted doc values (just like strings) so we will need to use the DocValueFormat to format the keys.
jpountz
force-pushed
the
enhancement/propagate_doc_value_format
branch
from
7df4143 to
13c1efd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR This commit should not have any impact on terms aggs, it will just make
supporting ipv6 easier.
Currently only the numeric terms aggs propagate the DocValueFormat instance since
we use numerics to represent also dates or ip addresses. Since string terms aggs
are only used for text/keyword/string fields, they do not use the format and just
call toUt8String(). However when we support ipv6, ip addresses as well will be
encoded in sorted doc values (just like strings) so we will need to use the
DocValueFormat to format the keys.