Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java API: Modified scrolling docs to match with the REST API docs #17579

Merged
merged 1 commit into from
Apr 7, 2016

Conversation

consulthys
Copy link
Contributor

Since SearchType.SCAN has been deprecated, the Java API docs needs to be modified to reflect that.
Closes #17555

@dadoonet
Copy link
Member

dadoonet commented Apr 7, 2016

That's great! Can you sign the CLA please?

@consulthys
Copy link
Contributor Author

As a matter of fact, I already did sign the CLA yesterday and got the document back via email.
Do I need to do anything else?

@dadoonet
Copy link
Member

dadoonet commented Apr 7, 2016

Did you sign the CLA with the same email address you used for your commits?
I can't see your name or github account in our CLA checker.

@dadoonet
Copy link
Member

dadoonet commented Apr 7, 2016

Could you send me your email address at david at elastic dot co so I can better check that?
May be we have a synchronisation issue on our end though...

@dadoonet dadoonet added the >docs General docs changes label Apr 7, 2016
@dadoonet dadoonet self-assigned this Apr 7, 2016
@dadoonet dadoonet merged commit 975094f into elastic:master Apr 7, 2016
dadoonet pushed a commit that referenced this pull request Apr 7, 2016
dadoonet pushed a commit that referenced this pull request Apr 7, 2016
@dadoonet
Copy link
Member

dadoonet commented Apr 7, 2016

Thank you! I also pushed it in 2.x and 2.3 branches

@consulthys
Copy link
Contributor Author

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Transport API Transport client API >docs General docs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants