Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate that rescore isn't allowed with retrievers, yet #118019

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Indicate that rescore isn't allowed with retrievers, yet #118019

merged 1 commit into from
Dec 4, 2024

Conversation

benwtrent
Copy link
Member

No description provided.

@benwtrent benwtrent added >docs General docs changes auto-backport Automatically create backport pull requests when merged :Search Relevance/Search Catch all for Search Relevance v9.0.0 v8.16.2 v8.17.1 v8.18.0 labels Dec 4, 2024
@benwtrent benwtrent requested a review from pmpailis December 4, 2024 18:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Dec 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

john-wagster
john-wagster approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit 9a81eb2 into main Dec 4, 2024
7 checks passed
@benwtrent benwtrent deleted the retrievers-doc-rescore-update branch December 4, 2024 19:10
This was referenced Dec 4, 2024
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.16 Commit could not be cherrypicked due to conflicts
✅ 8.17
✅ 8.x

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 118019

benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Dec 4, 2024
@benwtrent
Indicate that rescore isn't allowed with retrievers, yet (elastic#118019
5ef7d93 
)
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Dec 4, 2024
@benwtrent
Indicate that rescore isn't allowed with retrievers, yet (elastic#118019
3b24504 
)
benwtrent added a commit that referenced this pull request Dec 4, 2024
@benwtrent
[8.16] Indicate that rescore isn't allowed with retrievers, yet (#11…
693c492 
…8019)

Backports the following commits to 8.16:
 - Indicate that rescore isn't allowed with retrievers, yet (#118019)
@benwtrent benwtrent mentioned this pull request Dec 4, 2024
Merged
elasticsearchmachine pushed a commit that referenced this pull request Dec 4, 2024
@benwtrent
Indicate that rescore isn't allowed with retrievers, yet (#118019) (#…
d23a1ee 
…118021)
elasticsearchmachine pushed a commit that referenced this pull request Dec 4, 2024
@benwtrent
Indicate that rescore isn't allowed with retrievers, yet (#118019) (#…
ffea5a6 
…118022)
elasticsearchmachine pushed a commit that referenced this pull request Dec 4, 2024
@benwtrent
[8.16] Indicate that rescore isn't allowed with retrievers, yet (#11…
01e9388 
…8019) (#118023)

Backports the following commits to 8.16:
 - Indicate that rescore isn't allowed with retrievers, yet (#118019)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-wagster john-wagster john-wagster approved these changes

@pmpailis pmpailis Awaiting requested review from pmpailis

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged backport pending >docs General docs changes :Search Relevance/Search Catch all for Search Relevance Team:Docs Meta label for docs team Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.16.2 v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benwtrent @elasticsearchmachine @john-wagster