Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new offset_source field to store offsets referencing substrings of another field #118017

Merged
merged 10 commits into from
Dec 5, 2024

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Dec 4, 2024

This field is primarily designed for use with the semantic_text field, where it enables storing offsets that point to substrings of the field used to generate its underlying chunks.

To prevent external usage, the field is intentionally undocumented, with detailed javadocs explaining its specific purpose and limitations. I couldn’t find a way to fully block external usage, but skipping the docs should keep it mostly out of sight for now.

…gs of another field.

This field is primarily designed for use with the `semantic_text` field, where it enables storing offsets that point to substrings of the field used to generate its underlying chunks.

To prevent external usage, the field is intentionally undocumented, with detailed javadocs explaining its specific purpose and limitations.
I couldn’t find a way to fully block external usage, but skipping the docs should keep it mostly out of sight for now.
@jimczi jimczi requested review from Mikep86 and kderusso December 4, 2024 17:39
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Dec 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine
Copy link
Collaborator

Hi @jimczi, I've created a changelog YAML for you.

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the build is green

Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jimczi jimczi added auto-backport Automatically create backport pull requests when merged >non-issue and removed >feature labels Dec 5, 2024
@jimczi jimczi merged commit fdb1b2b into elastic:main Dec 5, 2024
16 checks passed
@jimczi jimczi deleted the offset_source_field branch December 5, 2024 14:20
jimczi added a commit to jimczi/elasticsearch that referenced this pull request Dec 5, 2024
…gs of another field. (elastic#118017)

This field is primarily designed for use with the `semantic_text` field, where it enables storing offsets that point to substrings of the field used to generate its underlying chunks.

To prevent external usage, the field is intentionally undocumented, with detailed javadocs explaining its specific purpose and limitations.
I couldn’t find a way to fully block external usage, but skipping the docs should keep it mostly out of sight for now.
@jimczi jimczi removed the auto-backport Automatically create backport pull requests when merged label Dec 5, 2024
@jimczi jimczi changed the title Add a new offset_source field to store offsets referencing substrings of another field. Add a new offset_source field to store offsets referencing substrings of another field Dec 5, 2024
elasticsearchmachine pushed a commit that referenced this pull request Dec 5, 2024
…gs of another field. (#118017) (#118088)

This field is primarily designed for use with the `semantic_text` field, where it enables storing offsets that point to substrings of the field used to generate its underlying chunks.

To prevent external usage, the field is intentionally undocumented, with detailed javadocs explaining its specific purpose and limitations.
I couldn’t find a way to fully block external usage, but skipping the docs should keep it mostly out of sight for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants