-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new offset_source
field to store offsets referencing substrings of another field
#118017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs of another field. This field is primarily designed for use with the `semantic_text` field, where it enables storing offsets that point to substrings of the field used to generate its underlying chunks. To prevent external usage, the field is intentionally undocumented, with detailed javadocs explaining its specific purpose and limitations. I couldn’t find a way to fully block external usage, but skipping the docs should keep it mostly out of sight for now.
elasticsearchmachine
added
the
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
label
Dec 4, 2024
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Hi @jimczi, I've created a changelog YAML for you. |
kderusso
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the build is green
...nference/src/main/java/org/elasticsearch/xpack/inference/mapper/OffsetSourceFieldMapper.java
Outdated
Show resolved
Hide resolved
...nce/src/test/java/org/elasticsearch/xpack/inference/mapper/OffsetSourceFieldMapperTests.java
Show resolved
Hide resolved
...inference/src/test/java/org/elasticsearch/xpack/inference/mapper/OffsetSourceFieldTests.java
Outdated
Show resolved
Hide resolved
carlosdelest
reviewed
Dec 5, 2024
...nference/src/main/java/org/elasticsearch/xpack/inference/mapper/OffsetSourceFieldMapper.java
Show resolved
Hide resolved
carlosdelest
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
jimczi
added
auto-backport
Automatically create backport pull requests when merged
>non-issue
and removed
>feature
labels
Dec 5, 2024
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Dec 5, 2024
…gs of another field. (elastic#118017) This field is primarily designed for use with the `semantic_text` field, where it enables storing offsets that point to substrings of the field used to generate its underlying chunks. To prevent external usage, the field is intentionally undocumented, with detailed javadocs explaining its specific purpose and limitations. I couldn’t find a way to fully block external usage, but skipping the docs should keep it mostly out of sight for now.
jimczi
removed
the
auto-backport
Automatically create backport pull requests when merged
label
Dec 5, 2024
jimczi
changed the title
Add a new
Add a new Dec 5, 2024
offset_source
field to store offsets referencing substrings of another field.offset_source
field to store offsets referencing substrings of another field
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 5, 2024
…gs of another field. (#118017) (#118088) This field is primarily designed for use with the `semantic_text` field, where it enables storing offsets that point to substrings of the field used to generate its underlying chunks. To prevent external usage, the field is intentionally undocumented, with detailed javadocs explaining its specific purpose and limitations. I couldn’t find a way to fully block external usage, but skipping the docs should keep it mostly out of sight for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>non-issue
:Search Relevance/Vectors
Vector search
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is primarily designed for use with the
semantic_text
field, where it enables storing offsets that point to substrings of the field used to generate its underlying chunks.To prevent external usage, the field is intentionally undocumented, with detailed javadocs explaining its specific purpose and limitations. I couldn’t find a way to fully block external usage, but skipping the docs should keep it mostly out of sight for now.