Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust index version for deprecating source mode #117183

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Nov 20, 2024

There was a bug in the version-checking logic for emitting deprecation warnings for source.mode in mappings.

@dnhatn dnhatn force-pushed the adjust-versions branch 8 times, most recently from 69d2fc2 to 94f8c6e Compare November 21, 2024 19:16
@dnhatn dnhatn added test-full-bwc Trigger full BWC version matrix tests :StorageEngine/Mapping The storage related side of mappings >non-issue labels Nov 25, 2024
@dnhatn dnhatn changed the title Adjust index versions Adjust index version for deprecating source mode Nov 25, 2024
@dnhatn dnhatn requested a review from martijnvg November 25, 2024 16:40
@dnhatn dnhatn marked this pull request as ready for review November 25, 2024 18:19
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@dnhatn
Copy link
Member Author

dnhatn commented Nov 25, 2024

I am merging this as @martijnvg has reviewed this already.

@dnhatn dnhatn merged commit 631345f into elastic:main Nov 25, 2024
16 checks passed
@dnhatn dnhatn deleted the adjust-versions branch November 25, 2024 18:21
dnhatn added a commit that referenced this pull request Nov 25, 2024
Adjust the deprecation index check to support the backport version in 8.x.

Relates #117183
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
There was a bug in the version-checking logic for emitting deprecation 
warnings for source.mode in mappings.
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
Adjust the deprecation index check to support the backport version in 8.x.

Relates elastic#117183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine test-full-bwc Trigger full BWC version matrix tests v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants