Search Queries in parallel - part 3 #117149
Conversation
drempapis
added
Team:Search Foundations
|
@elasticmachine update branch |
drempapis
changed the title
|
@elasticmachine update branch |
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
server/src/internalClusterTest/java/org/elasticsearch/aliases/IndexAliasesIT.java
Show resolved
Hide resolved
| assertResponse( | ||
| assertResponses(response -> { | ||
| assertHitCount(response, 3); | ||
| assertThat(response.getHits().getMaxScore(), equalTo(response.getHits().getHits()[0].getScore())); |
There was a problem hiding this comment.
I would assume that this is safe, but this is a new addition for this test block, right?
There was a problem hiding this comment.
Just noticed it below; in L#174 :)
There was a problem hiding this comment.
I considered adding an assertion for the first prepareSearch request safe. I did that to group calls under assertResponses. The opposite would be problematic.
server/src/internalClusterTest/java/org/elasticsearch/search/query/MultiMatchQueryIT.java
Outdated
Show resolved
Hide resolved
...lClusterTest/java/org/elasticsearch/search/fetch/subphase/highlight/HighlighterSearchIT.java
Outdated
Show resolved
Hide resolved
...lClusterTest/java/org/elasticsearch/search/fetch/subphase/highlight/HighlighterSearchIT.java
Outdated
Show resolved
Hide resolved
...lClusterTest/java/org/elasticsearch/search/fetch/subphase/highlight/HighlighterSearchIT.java
Outdated
Show resolved
Hide resolved
...lClusterTest/java/org/elasticsearch/search/fetch/subphase/highlight/HighlighterSearchIT.java
Outdated
Show resolved
Hide resolved
| prepareSearch("test", "foos").setQuery(QueryBuilders.matchAllQuery()), | ||
| searchResponse -> assertHits(searchResponse.getHits(), "1", "2", "3", "4") | ||
| ); | ||
|
|
||
| logger.info("--> checking index and alias wildcard search"); |
There was a problem hiding this comment.
I think it's fine to delete these log lines, there's little to no value in them now that they don't correspond to exactly when the queries run anymore.
There was a problem hiding this comment.
Thank you @original-brownbear. I will proceed with those deletions before merging. I am on the same page
please see #116812