Unmuting chunking test #116837
Merged
Unmuting chunking test #116837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-rubinstein
added
>test
elasticsearchmachine
added
the
external-contributor
dan-rubinstein
removed
the
external-contributor
|
Pinging @elastic/ml-core (Team:ML) |
prwhelan
approved these changes
Nov 21, 2024
|
@elasticmachine merge upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was muted until we backported this change to 8.x which was completed as part of this PR. It had to be muted because the test puts an inference endpoint with chunking settings provided and then checks that either the put succeeded (requires 8.x to be aware of chunking settings which only happens after the backport) or the put fails with an inference index out of date exception if the "old node" handling the request has not been updated (this exception is only thrown after the backport to 8.x). Given that we've completed the backport, we can now unmute this test.