Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport entitlements work to date from main to 8.x #115950

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

prdoyle
Copy link
Contributor

@prdoyle prdoyle commented Oct 30, 2024

No description provided.

prdoyle and others added 3 commits October 30, 2024 11:07
* Initial hello-world entitlements agent

* Respond to Ryan's comments

* License header

* Fix forbidden APIs setup

* Rename EntitlementAgent

* Automated refactor missed one

* Automated rename really let me down here

* Very serious test name

* README files for the new modules

* Use "tasks.named('jar')"

Co-authored-by: Rene Groeschke <rene@breskeby.com>

* Use 'tasks.named('test')'

Co-authored-by: Rene Groeschke <rene@breskeby.com>

* More deferral of gradle tasks

Co-authored-by: Rene Groeschke <rene@breskeby.com>

* Even more deferral

Co-authored-by: Rene Groeschke <rene@breskeby.com>

* FIx gradle syntax for javaagent arg

---------

Co-authored-by: Rene Groeschke <rene@breskeby.com>
* Entitlements for System.exit

* Respond to Simon's comments

* Rename trampoline -> bridge

* Require exactly one bridge jar

* Use Type helpers to generate descriptor strings

* Various cleanup from PR comments

* Remove null "receiver" for static methods

* Use List<Type> instead of voidDescriptor

* Clarifying comment

* Whoops, getMethod

* SuppressForbidden System.exit

* Spotless

* Use embedded provider plugin to keep ASM off classpath

* Oops... forgot the punchline

* Move ASM license to impl

* Use ProviderLocator and simplify bridgeJar logic

* Avoid eager resolution of configurations during task configuration

* Remove compile-time dependency agent->bridge

---------

Co-authored-by: Mark Vieira <portugee@gmail.com>
* Initial InstrumenterTests

* Assert on instrumentation method arguments
@prdoyle prdoyle marked this pull request as ready for review October 30, 2024 15:10
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.17.0 labels Oct 30, 2024
@prdoyle prdoyle added >non-issue :Core/Infra/Core Core issues without another label labels Oct 30, 2024
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team and removed needs:triage Requires assignment of a team area label labels Oct 30, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@prdoyle prdoyle enabled auto-merge (squash) October 30, 2024 15:36
@prdoyle prdoyle disabled auto-merge October 30, 2024 16:33
@prdoyle prdoyle merged commit 0fabcf2 into elastic:8.x Oct 30, 2024
15 checks passed
@prdoyle prdoyle deleted the backport-entitlements branch October 30, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v8.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants