Make sure _MSC_VER is defined before checking #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids the following:
error: "_MSC_VER" is not defined, evaluates to 0 [-Werror=undef]
59 | #if _MSC_VER <= 1900
| ^~~~~~~~
|
Starting integration testing with BRL-CAD, hit that error from linalg.h with our build flags. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #990 +/- ##
==========================================
- Coverage 91.84% 86.38% -5.46%
==========================================
Files 37 62 +25
Lines 4976 9093 +4117
Branches 0 1049 +1049
==========================================
+ Hits 4570 7855 +3285
- Misses 406 1238 +832 ☔ View full report in Codecov by Sentry. |
pca006132
approved these changes
Oct 16, 2024
RahimovIR
pushed a commit
to RahimovIR/manifold
that referenced
this pull request
Oct 18, 2024
Avoids the following:
error: "_MSC_VER" is not defined, evaluates to 0 [-Werror=undef]
59 | #if _MSC_VER <= 1900
| ^~~~~~~~
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the following:
error: "_MSC_VER" is not defined, evaluates to 0 [-Werror=undef]
59 | #if _MSC_VER <= 1900
| ^~~~~~~~