gh-md-toc fails silently with an empty toc on lack of network connectivity #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. I saw the travis test is failing. After having a closer and running the tests locally on the current master, it looks like it comes from the remote examples which changed structures. Should I fix this in this same PR ? |
|
Hi @zeitounator Thanks for the PR!
No, you should not. It's not related to your changes. |
|
@ekalinin My pleasure ! Thanks for your fast reaction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally took the time to find out why I was getting empty tocs once in a while....
I move between my personal office and clients location where I'm frequently behind a proxy. I don't always set the outgoing proxy in my shell. It happens that gh-md-toc needs network connectivity, even to parse local file. But it fails silently with an empty toc in those cases. This is misleading.
This PR fixes this and fails with a message to check network connection, both for remote and local files.