Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for others messages to be used as RL messages #56

Closed
Edwinexd opened this issue Feb 8, 2021 · 2 comments · Fixed by #57
Closed

Add support for others messages to be used as RL messages #56

Edwinexd opened this issue Feb 8, 2021 · 2 comments · Fixed by #57
Labels
enhancement Software improvement new feature A new feature would be introduced

Comments

@Edwinexd
Copy link
Contributor

Edwinexd commented Feb 8, 2021

Is your feature request related to a problem? Please describe.

- (See Describe the solution you'd like)

Describe the solution you'd like

I'd like to be able to use other users messages e.g. users or other bots messages as reaction messages instead of only being able to use the bots own messages as "role switchers". The use case for this is when you for example have multiple rule messages but only need reaction capability on one of them.

The solution I'm thinking is by adding an option in the RL creation process to use a existing message or create one using the bot.

Describe alternatives you've considered

Creating reaction light messages that have no emoji/role combinations attached to them. I've decided against using this due to the unnecessary DB-entries. I've also considered to just add a entry to the database manually but thought others might have the same use case.

Additional context

I can help implement it, just want to see it is something that is seem fit inside the scope of the project.
@Edwinexd Edwinexd added enhancement Software improvement new feature A new feature would be introduced labels Feb 8, 2021
@eibex
Copy link
Owner

eibex commented Feb 8, 2021

Hey, this was actually on my pre-1.0.0 roadmap and I forgot about it when working on other core functionalities.

This is definitely something that could be implemented, but I wonder if there's any way to implement this efficiently without using developer mode (I think we would need to feed the bot with the message id). Do you have any idea to do this without developer mode?

The only thing that comes to mind is something that lists messages like rl!edit when there are multiple reactionrole messages in the same channel. But that would feel extremely tedious.

Otherwise we could make an exception to the rule since this would be an extra feature that is already covered by a solution that doesn't rely on developer mode.

Instead of making a new command I would probably modify the on_message event step that asks to insert the text for the reaction role message to also accept the option of a message id.

Let me know if you have any opinion on anything that I just wrote.

@eibex
Copy link
Owner

eibex commented Feb 8, 2021

Another option would be to make the rl!new command accept an optional argument which would be the target message id.

If this was selected the reactionrole message creation process would finish before asking the user to insert the text data for the embed and just add the reactions to the target message.

The downside of this is that users would need to actually read the README or the rl!help information to know this functionality exists.

@Edwinexd Edwinexd mentioned this issue Feb 12, 2021
Merged
@eibex eibex closed this as completed in #57 Feb 13, 2021
Repository owner deleted a comment from Edwinexd Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Software improvement new feature A new feature would be introduced
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for others messages Edwinexd/reaction-light
2 participants
@eibex @Edwinexd