Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate onlyChanges #907

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Deprecate onlyChanges #907

merged 2 commits into from
Jul 19, 2023

Conversation

zerobias
Copy link
Member

No description provided.

@stackblitz
Copy link

stackblitz bot commented May 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@zerobias zerobias mentioned this pull request May 20, 2023
Closed
75 tasks
@zerobias zerobias added this to the effector Spacewatch 23.0.0 milestone May 20, 2023
sergeysova added a commit that referenced this pull request Jun 10, 2023
@sergeysova
docs: deprecate onlyChanges in serialize
5400f10 
Implemented in #907
@sergeysova sergeysova changed the base branch from master to release/v23 July 6, 2023 06:41
@zerobias zerobias merged commit b947a13 into release/v23 Jul 19, 2023
@zerobias zerobias deleted the deprecate-onlyChanges branch July 19, 2023 13:17
@darky
Copy link
Contributor

darky commented Oct 4, 2024

Why it was deprecated? How to serialize onlyChanges in future Effector 24?

@kireevmp
Copy link
Contributor

kireevmp commented Oct 9, 2024

Hey @darky,
Starting from Effector 22, onlyChanges: true is the default option for serialize (changelog).

In this PR, we're only deprecating the old fork + serialize behavior, which specifically required explicitly passing a Domain to track units.

Since v22, Domain is no longer necessary, so both fork(domain) and serialize(scope, { onlyChanges: false }) are deprecated.

@darky
Copy link
Contributor

darky commented Oct 9, 2024

@kireevmp thanks for explanation! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
effector Spacewatch 23.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zerobias @darky @kireevmp