Remove thru method #843
Merged
Remove thru method #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 tasks
zerobias
commented
Feb 2, 2023
Comment on lines
-116
to
-119
| No overload matches this call. | ||
| The last overload gave the following error. | ||
| Argument of type 'Effect<any, number, Error>' is not assignable to parameter of type 'Event<string>'. | ||
| Property 'thru' is missing in type 'Effect<any, number, Error>' but required in type 'Event<string>'. |
There was a problem hiding this comment.
restore is broken because it was dependent on .thru
const ev = createEvent<number>()
restore(ev, 'initial')
zerobias
commented
Feb 2, 2023
| @@ -92,7 +92,8 @@ test('useEvent of Effect<void, unknown, Error>', () => { | |||
| useEvent(createEffect<void, unknown, Error>()) | |||
| expect(typecheck).toMatchInlineSnapshot(` | |||
| " | |||
| no errors | |||
| Type '() => void' is not assignable to type '() => Promise<unknown>'. | |||
| Type 'void' is not assignable to type 'Promise<unknown>'. | |||
There was a problem hiding this comment.
useEvent is broken for unknown reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.