Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample target forwarding typings #248

Merged
merged 4 commits into from
Nov 15, 2019
Merged

Sample target forwarding typings #248

merged 4 commits into from
Nov 15, 2019

Conversation

bloadvenro
Copy link
Contributor

  • test suit for sample cases using target forwarding
  • add NoInfer type hint to sample overloads using target

This will fix #247

@vercel
Copy link

vercel bot commented Nov 15, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/zerobias/effector/dig9mr1nn
🌍 Preview: https://effector-git-fork-bloadvenro-sample-target-forwarding-typings.zerobias.now.sh

@zerobias
Copy link
Member

Cool, thanks! 👍

@zerobias zerobias merged commit 5b48555 into effector:master Nov 15, 2019
@bloadvenro bloadvenro deleted the sample-target-forwarding-typings branch November 16, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TS] sample with target: "best common type" problem
2 participants
@bloadvenro @zerobias