Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: allow unsetting variables in configuration files #593

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

kareefardi
Copy link
Collaborator

@kareefardi kareefardi commented Nov 3, 2024

Misc. Enhancements/Bugfixes

  • Fixed undefining variables in configuration files being ignored.
  • Restored VERILOG_POWER_DEFINE as an optional variable.

Steps

  • Yosys.JsonHeader, Verilator.Lint, Odb.WriteVerilogHeader

    • Handled undefined VERILOG_POWER_DEFINE.

Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@kareefardi kareefardi requested a review from donn November 3, 2024 11:13
@kareefardi kareefardi marked this pull request as ready for review November 3, 2024 11:13
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@openlane-bot
Copy link
Collaborator

openlane-bot commented Nov 3, 2024

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch main --table-verbosity ALL --table-out ./tables_all.md.

  • No changes to critical metrics were detected in analyzed designs.

Full tables ► https://gist.github.com/openlane-bot/d8e51fd3b343515382360191bcbb6397

@donn donn force-pushed the fix-power-defines branch from 4bcbede to d752fbd Compare November 10, 2024 10:42
@kareefardi kareefardi enabled auto-merge (squash) November 10, 2024 10:46
@kareefardi kareefardi merged commit 771a73e into main Nov 10, 2024
107 checks passed
@donn donn deleted the fix-power-defines branch December 16, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants