Add options for generated enum format. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerimoq
reviewed
May 2, 2023
|
I'm tempted to never add the enum name itself as a prefix, and just rely on that enum field names are according to protobuf recommendation. That is, we can remove the --enum-prefix argument. |
Are you saying that the format should not even include namespace? |
|
The latter. It should include everything except the name of the enum. |
|
I'll fix tests and clean it up. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I too ran into this issue #9. Here is one way to handle that.
I addition, I usually use all upper case for enum constants, so I added an option for that as well.