Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion regarding info for Chinese locales in README #2367

Closed
antermin opened this issue May 27, 2024 · 4 comments
Closed

Suggestion regarding info for Chinese locales in README #2367

antermin opened this issue May 27, 2024 · 4 comments

Comments

@antermin
Copy link

thorium-reader/README.md

Lines 22 to 23 in 4f0a1ba

* (zh-CN) 中文 - 中國/国 (Chinese simp.)
* (zh-TW) 中文 - 台湾/灣 (Chinese trad.)

The list of locales uses the format (Language code) Native name (English name).

For zh-CN, the native name field should be in Simplified Chinese characters.
For zh-TW, the native name field should be in Traditional Chinese characters.

Therefore it is redundant to mix both sets of characters (中國/国 and 台湾/灣) and it can be simplified to:

* (zh-CN) 中文 - 中国 (Chinese simp.)
* (zh-TW) 中文 - 台灣 (Chinese trad.)

There are also some other ways depending on how you want to list the Chinese locales.

Match native name to English name:

* (zh-CN) 简体中文 (Chinese simp.)
* (zh-TW) 繁體中文 (Chinese trad.)

Match English name to native name:

* (zh-CN) 中文 - 中国 (Chinese - China)
* (zh-TW) 中文 - 台灣 (Chinese - Taiwan)

Be very detailed (stating both the character set and the variant:

* (zh-CN) 简体中文 - 中国 (Simplified Chinese - China)
* (zh-TW) 繁體中文 - 台灣 (Traditional Chinese - Taiwan)
@danielweck
Copy link
Member

Thank you, we will update the README based on your recommendations.

Could you please check that the description that appears in Thorium's language selector is correct:

thorium-reader/src/common/services/translator.ts

Lines 179 to 180 in 81b1e93

"zh-TW": "繁体中文 - 中國/国 (Chinese trad.)",
"zh-CN": "简体中文 - 台湾/灣 (Chinese simp.)",

@danielweck danielweck mentioned this issue May 27, 2024
Closed
@danielweck
Copy link
Member

danielweck commented May 27, 2024 •
edited
Loading

Comment from @Leroy-X #2357 (comment)

image

Hi, there is still a problem in 3.0. The Chinese characters marked by the red line are upside down. :P

Correct should be:
简体中文 - 中国（Chinese Simp.）
繁體中文 - 台灣（Chinese Trad.）

danielweck added a commit that referenced this issue May 27, 2024
@danielweck
fix: Chinese locale names in language settings (Fixes #2367)
01b0fda
@danielweck
Copy link
Member

Hello @arthur-lemeur I made the combobox a little wider to accommodate longer locale names, I tested with Thorium's minimum window dimensions, and I checked all other occurrences of shared combobox styles (I was worried about the usual CSS side effects / leakage). All seems ok, but just wanted to let you know:
01b0fda#diff-9ac427bfb77c4b749bc13b74dab53c7aa1ca76246b2864c23e1f132f8a5bf77c

@antermin
Copy link
Author

I've checked the latest README and the latest binary (EDRLab.ThoriumReader_3.0.0-alpha.1.9260317835_amd64).
Locales and descriptions are correct now.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielweck @antermin