Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(svg): SVG <image> tag also should consider href attribute. #803

Merged
merged 1 commit into from
Aug 25, 2021
Merged

fix(svg): SVG <image> tag also should consider href attribute. #803

merged 1 commit into from
Aug 25, 2021

Conversation

plainheart
Copy link
Collaborator

Resolves apache/echarts#15597

The image element in SVG support both xlink:href attribute and link attribute. xlink:href seems not recommended anymore. But at least, we should consider supporting the link attribute.

@pissang pissang merged commit 6a71b1e into master Aug 25, 2021
@pissang pissang deleted the fix-svg-parse branch August 25, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pissang pissang pissang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<image> tags in Geo SVGs are not loading
2 participants
@plainheart @pissang