Add an option to the product editor to flag it contain a JRE #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
force-pushed
the
support_flag_for_jre
branch
from
568e3d2 to
fd108fc
Compare
HannesWell
reviewed
Jan 27, 2024
ui/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/pderesources.properties
Show resolved
Hide resolved
See #1077 |
Currently if one wants to include a JRE it is needed to specify a concrete EE for each of the linux/win/mac what is quite cumbersome and could easily forgotten to update. Instead this adds a new flag "includeJRE" in the product that enables this for all os at once and always uses the default vm (what is the one from the target platform or user chosen default). This will also make it easier for Tools like Tycho that already investigate the 'includeLaunchers' flag.
laeubi
force-pushed
the
support_flag_for_jre
branch
from
fd108fc to
890bea0
Compare
laeubi
added a commit
to laeubi/tycho
that referenced
this pull request
May 5, 2024
PDE recently added a new flag for the product to mark it to include a jre eclipse-pde/eclipse.pde#1075 but this currently has no effect in Tycho. This now adds support for automatically include a JustJ JRE if the option is selected.
laeubi
added a commit
to laeubi/tycho
that referenced
this pull request
May 5, 2024
PDE recently added a new flag for the product to mark it to include a jre eclipse-pde/eclipse.pde#1075 but this currently has no effect in Tycho. This now adds support for automatically include a JustJ JRE if the option is selected.
laeubi
added a commit
to laeubi/tycho
that referenced
this pull request
May 5, 2024
PDE recently added a new flag for the product to mark it to include a jre eclipse-pde/eclipse.pde#1075 but this currently has no effect in Tycho. This now adds support for automatically include a JustJ JRE if the option is selected.
laeubi
added a commit
to laeubi/tycho
that referenced
this pull request
May 5, 2024
PDE recently added a new flag for the product to mark it to include a jre eclipse-pde/eclipse.pde#1075 but this currently has no effect in Tycho. This now adds support for automatically include a JustJ JRE if the option is selected. Fix eclipse-tycho#2064
laeubi
added a commit
to laeubi/tycho
that referenced
this pull request
May 5, 2024
PDE recently added a new flag for the product to mark it to include a jre eclipse-pde/eclipse.pde#1075 but this currently has no effect in Tycho. This now adds support for automatically include a JustJ JRE if the option is selected. Fix eclipse-tycho#2064
laeubi
added a commit
to eclipse-tycho/tycho
that referenced
this pull request
May 5, 2024
PDE recently added a new flag for the product to mark it to include a jre eclipse-pde/eclipse.pde#1075 but this currently has no effect in Tycho. This now adds support for automatically include a JustJ JRE if the option is selected. Fix #2064
laeubi
added a commit
to laeubi/tycho
that referenced
this pull request
May 5, 2024
PDE recently added a new flag for the product to mark it to include a jre eclipse-pde/eclipse.pde#1075 but this currently has no effect in Tycho. This now adds support for automatically include a JustJ JRE if the option is selected. Fix eclipse-tycho#2064
laeubi
added a commit
to eclipse-tycho/tycho
that referenced
this pull request
May 5, 2024
PDE recently added a new flag for the product to mark it to include a jre eclipse-pde/eclipse.pde#1075 but this currently has no effect in Tycho. This now adds support for automatically include a JustJ JRE if the option is selected. Fix #2064
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if one wants to include a JRE it is needed to specify a concrete EE for each of the linux/win/mac what is quite cumbersome and could easily forgotten to update.
Instead this adds a new flag "includeJRE" in the product that enables this for all os at once and always uses the default vm (what is the one from the target platform or user chosen default).
This will also make it easier for Tools like Tycho that already investigate the 'includeLaunchers' flag.