Renaming earth to earthly #618
Conversation
alexcb
force-pushed
the
rename-earth-to-earthly
branch
13 times, most recently
from
5aae405 to
acfbaea
Compare
| @@ -8,12 +8,12 @@ import ( | |||
| "github.com/pkg/errors" | |||
| ) | |||
|
|
|||
| // EarthIgnoreFile is the name of the earth ignore file. | |||
| // EarthIgnoreFile is the name of the earthly ignore file. | |||
| const EarthIgnoreFile = ".earthignore" | |||
There was a problem hiding this comment.
we're going to need some backwards compatibility if we want to rename this to .earthlyignore
There was a problem hiding this comment.
The other possible one is Earthfile... Perhaps let's leave them like this for now.
There was a problem hiding this comment.
- Also rename
docker2earth? earthApp->earthlyAppin main.go- Some other (maybe not very important) variables names still have names like
earthTargetName(egartifact.go). I guess it's ok to skip them for now. - Docs will be done in separate PR branched off
next, right? - Changes to add symlink via bootstrap will be done in separate PR, right?
earthly
Outdated
| @@ -1,12 +1,12 @@ | |||
| #!/bin/bash | |||
| set -e | |||
|
|
|||
| bindir="$HOME/.earthly" | |||
| bindir="$HOME/.earth" | |||
There was a problem hiding this comment.
Why not use .earthly for this too?
There was a problem hiding this comment.
good catch, this was a mistaken search/replace.
README.md
Outdated
| @@ -319,7 +319,7 @@ release: | |||
| ``` | |||
|
|
|||
| ```bash | |||
| earth --secret GITHUB_TOKEN --push +release | |||
| earthly --secret GITHUB_TOKEN --push +release | |||
There was a problem hiding this comment.
Make changes in README on next branch instead?
There was a problem hiding this comment.
that's a good call, I left out the docs renaming for a different PR but let the README changes slip in, i'll save these for a future PR.
README.md
Outdated
| * #️⃣ [Earth command reference](https://docs.earthly.dev/earth-command) | ||
| * ⚙️ [Configuration reference](https://docs.earthly.dev/earth-config) | ||
| * #️⃣ [Earth command reference](https://docs.earthly.dev/earthly-command) | ||
| * ⚙️ [Configuration reference](https://docs.earthly.dev/earthly-config) |
There was a problem hiding this comment.
Note that these will require redirects in gitbook. See https://docs.gitbook.com/integrations/github/content-configuration
- when a user installs via brew, they type brew install earthly, so one would expect to find a command named earthly rather than earth this git repo is located at github.com/earthly/earthly.git and not github.com/earthly/earth.git - Googling for earthly manages to find our documentation, where as the search-space for earth is much more crowded - earth easily tabs completes into earthly
alexcb
force-pushed
the
rename-earth-to-earthly
branch
from
acfbaea to
9c03e71
Compare
|
I renamed earthApp to earthlyApp in this PR; I'm hoping to do a follow up PR for docs, readmes, and other variable renames and more significant code changes like the bootstraping logic. |
brew install earthly, so one would expect to find a command namedearthlyrather thanearthgithub.com/earthly/earthly.gitand notgithub.com/earthly/earth.gitearthlymanages to find our documentation, where as the search-space forearthis much more crowdedeartheasily tabs completes intoearthly