Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more meaningful installation error messages #216

Merged
merged 2 commits into from
Feb 4, 2023
Merged

more meaningful installation error messages #216

merged 2 commits into from
Feb 4, 2023

Conversation

line-o
Copy link
Member

@line-o line-o commented Feb 3, 2023 •
edited
Loading

Before:

[15:45:14] Error in plugin "gulp-exist"
Message:
    XAR was not uploaded
Details:
    domainEmitter: [object Object]

With this PR merged

[16:12:58] Error in plugin "gulp-exist"
Message:
    XAR was not uploaded: Error: connect ECONNREFUSED 127.0.0.1:8443
Details:
    domainEmitter: [object Object]

@line-o line-o force-pushed the feat/install-errors branch from ded5d8d to b382f1f Compare February 3, 2023 15:10
line-o added 2 commits February 3, 2023 16:10
@line-o
ci: test on latest versions
b4ff274
@line-o
feat: improve installation error messages
13ba419 
Provide the user with a more meaningful error message,
when a package cannot be uploaded or the installation
failed.
@line-o line-o force-pushed the feat/install-errors branch from b382f1f to 13ba419 Compare February 3, 2023 15:10
@line-o line-o requested a review from a team February 3, 2023 16:15
duncdrum
duncdrum approved these changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@duncdrum duncdrum merged commit e02da38 into eXist-db:main Feb 4, 2023
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncdrum duncdrum duncdrum approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@line-o @duncdrum