Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toggle-button-group): fixed buttons per row and added min layout exceptions #2406

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Jul 30, 2024

Fixes #2401

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  1. I fixed the list and gallery variation minimal screen/container buttons so that any container/screen under 320px will use the actual css props. The css props implemented initially weren't actually being used for the respective button layouts.
  2. I changed the default gallery variation minimal screen/container (< 320px) buttons to 2 since it has since now been using that inheriting the min layout button css prop, to avoid breaking current implementations and since it looks better overall.
  3. I added 3 minimal layout (< 320px) exceptions for more implementation flexibility with any of the layout type buttons.
  4. I added a few stories, both for the missing use cases and for the new minimal container exceptions for all the button layouts.

Screenshots

Before

image

After

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue requested review from agliga and LuLaValva July 30, 2024 16:47
@ArtBlue ArtBlue self-assigned this Jul 30, 2024
Copy link

changeset-bot bot commented Jul 30, 2024

🦋 Changeset detected

Latest commit: cbd44f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment

@ArtBlue ArtBlue merged commit f151214 into 18.1.0 Jul 30, 2024
@ArtBlue ArtBlue deleted the 2401-toggle-button-group-min-layouts branch July 30, 2024 20:00
This was referenced Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants