feat(badge): evo updates #1493 #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I think we should just bite the bullet and add a new flex container if that's what we need to do. That |
|
Small padding adjustment. The single digit now looks more centered.
Let's merge this PR, as it improves the currently broken state of badge in 13.0.0 branch. Then we can investigate the additional element in a follow up. I think it would certainly simplify the CSS and be more robust across browsers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1493
Updates badge, icon-button, menu & menu-button with latest badge styles from evo.
There's a little bit of hackery with padding to get the text lining up right. Some numbers can look a little uncentered across different browsers. The outer padding when number grows to 2 digit isn't exactly in line with the designs either. I think this is about the most precision we can get though without going and adding a new flex element inside the badge (i.e. a nested span). I'm not opposed to doing that if we have to.
Also, I'll probably come back and fine tune the position of the badge on the icon button. The
topandleftmight need a little adjustment.I also had to add a new
menu__item--badgedmodifier. This will need adding in coreui.