Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toggle-button-group): added min columns option #2228

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Aug 7, 2024

Description

Add support for the recently added data-columns-min in Skin for the default/minimum container number of buttons in a row.

Context

This will allow users of ebay ui to have preferred columns of buttons for the smallest container.

Links

The companion to the Skin update: eBay/skin#2406

@ArtBlue ArtBlue requested review from agliga and LuLaValva August 7, 2024 20:54
@ArtBlue ArtBlue self-assigned this Aug 7, 2024
Copy link

changeset-bot bot commented Aug 7, 2024

🦋 Changeset detected

Latest commit: 60f4658

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just add a changeset

@ArtBlue ArtBlue merged commit b1f4dc1 into 14.2.0 Aug 7, 2024
4 checks passed
@ArtBlue ArtBlue deleted the 2227-toggle-button-group-min-columns branch August 7, 2024 21:41
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
@github-actions github-actions bot mentioned this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants