fix(ebay-icon): added gradient support on server side rendering #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 814bcb1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agliga
force-pushed
the
gradient-server-icons
branch
from
a2571e6 to
7a752ad
Compare
LuLaValva
changed the title
agliga
force-pushed
the
gradient-server-icons
branch
from
7a752ad to
ea77701
Compare
LuLaValva
previously approved these changes
Mar 6, 2024
agliga
force-pushed
the
gradient-server-icons
branch
from
ea77701 to
0905866
Compare
agliga
changed the title
agliga
force-pushed
the
gradient-server-icons
branch
from
0905866 to
814bcb1
Compare
LuLaValva
approved these changes
Mar 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering ebay-icon on the server, we add the symbol to the html rendering and then that symbol gets stripped and added in the head.
This was not being done for gradient icons and causing an issue when SSR icons.
This change adds a fix to render the gradient portion in the icon and strip it out.