fix: logic for collapse-on-select was backwards (#2315)

=
eBay · Nov 1, 2024 · d53c7f6 · d53c7f6
1 parent eff515a
commit d53c7f6
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/hungry-stingrays-chew.md b/.changeset/hungry-stingrays-chew.md
@@ -0,0 +1,5 @@
+---
+"@ebay/ebayui-core": patch
+---
+
+Fix collapseOnSelect
diff --git a/src/components/ebay-listbox-button/component.ts b/src/components/ebay-listbox-button/component.ts
@@ -52,7 +52,7 @@ class ListboxButton extends Marko.Component<Input, State> {
     }
 
     handleListboxChange(event: ChangeEvent) {
-        if (this.input.collapseOnSelect === false) {
+        if (this.input.collapseOnSelect !== false) {
             this._expander.expanded = false;
         }
         const selectedIndex = event.index;

diff --git a/src/components/ebay-listbox-button/test/test.browser.js b/src/components/ebay-listbox-button/test/test.browser.js
@@ -157,6 +157,13 @@ describe("given the listbox is in an expanded state", () => {
                 .has.property("selected")
                 .and.is.deep.equal([options[1].value]);
         });
+
+        it("then it has collapsed the listbox", () => {
+            expect(component.getByRole("button")).toHaveAttribute(
+                "aria-expanded",
+                "false",
+            );
+        });
     });
 
     describe("when the down arrow key is pressed", () => {