Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider all oos elements if required in network x graph #2388

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

SimonRubenDrauz
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.61%. Comparing base (1fb8de3) to head (b035993).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
pandapower/topology/create_graph.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2388   +/-   ##
========================================
  Coverage    75.61%   75.61%           
========================================
  Files          284      284           
  Lines        33797    33797           
========================================
  Hits         25554    25554           
  Misses        8243     8243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pawellytaev pawellytaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog and the docstring for the include_out_of_service parameter

@vogt31337
Copy link
Contributor

@SimonRubenDrauz, please add a changelog entry.

@SimonRubenDrauz
Copy link
Contributor Author

Done!

@pawellytaev pawellytaev merged commit 90f07d4 into e2nIEE:develop Jan 8, 2025
18 of 25 checks passed
@SimonRubenDrauz SimonRubenDrauz deleted the fix/elements_oos branch January 8, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants