Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COLIB-NGC] T1.2 add GovHydro4 #3107

Open
martinscripts opened this issue Jan 18, 2024 · 0 comments · May be fixed by #3393
Open

[COLIB-NGC] T1.2 add GovHydro4 #3107

martinscripts opened this issue Jan 18, 2024 · 0 comments · May be fixed by #3393
Assignees
@martinscripts
Labels
Models library

Comments

@martinscripts
Copy link
Collaborator

This is an issue in the context of the project COLIB NGC. For documentation about these models, see colib0.

To be developed here:

  • modelica simulation model
  • validation
@martinscripts martinscripts changed the title [COLIB-NGC] add GovHydro4 [COLIB-NGC] T1.2 add GovHydro4 Jan 18, 2024
martinscripts added a commit to martinscripts/dynawo that referenced this issue Sep 11, 2024
@martinscripts
dynawo#3107 add govHydro4
076e00d 
Signed-off-by: Martin Franke <franke_martin@gmx.net>
@joyelfeghali joyelfeghali linked a pull request Sep 30, 2024 that will close this issue
[COLIB-NGC] #3107 add govHydro4 #3393
Open
4 tasks
martinscripts added a commit to martinscripts/dynawo that referenced this issue Dec 3, 2024
@martinscripts
dynawo#3107 add govHydro4
cbad117 
Signed-off-by: Martin Franke <franke_martin@gmx.net>

changed unit of one parameter

correct unit for unintentional deadband

deleted wrong limit in omega db

fix type

Signed-off-by: Martin Franke <franke_martin@gmx.net>

fix elseif

Signed-off-by: Martin Franke <franke_martin@gmx.net>

fix param name

Signed-off-by: Martin Franke <franke_martin@gmx.net>

add review changes

Signed-off-by: Martin Franke <franke_martin@gmx.net>

fix

Signed-off-by: Martin Franke <franke_martin@gmx.net>
@martinscripts martinscripts reopened this Dec 4, 2024
joyelfeghali added a commit that referenced this issue Dec 9, 2024
@joyelfeghali
#3107 Add Dynawo test case for GovHydro4
771c9a7 
Signed-off-by: Joy El Feghali <joy.elfeghali@rte-france.com>
joyelfeghali pushed a commit that referenced this issue Dec 11, 2024
@martinscripts @joyelfeghali
#3107 add govHydro4
993715d 
Signed-off-by: Martin Franke <franke_martin@gmx.net>

changed unit of one parameter

correct unit for unintentional deadband

deleted wrong limit in omega db

fix type

Signed-off-by: Martin Franke <franke_martin@gmx.net>

fix elseif

Signed-off-by: Martin Franke <franke_martin@gmx.net>

fix param name

Signed-off-by: Martin Franke <franke_martin@gmx.net>

add review changes

Signed-off-by: Martin Franke <franke_martin@gmx.net>

fix

Signed-off-by: Martin Franke <franke_martin@gmx.net>
joyelfeghali added a commit that referenced this issue Dec 11, 2024
@joyelfeghali
#3107 Add Dynawo test case for GovHydro4
5d147ec 
Signed-off-by: Joy El Feghali <joy.elfeghali@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinscripts martinscripts

Labels
Models library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[COLIB-NGC] #3107 add govHydro4 martinscripts/dynawo
2 participants
@martinscripts @rosiereflo