Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle all failures when pwd does not exist. #857

Merged
merged 7 commits into from
Jan 31, 2023
Merged

Handle all failures when pwd does not exist. #857

merged 7 commits into from
Jan 31, 2023

Conversation

jctanner
Copy link
Contributor

@jctanner jctanner commented Jan 31, 2023 •
edited
Loading

Fixes #853

Reproducer:

#!/bin/bash

rm -rf /tmp/foobar
mkdir -p /tmp/foobar
cd /tmp/foobar
rm -rf /tmp/foobar


echo "PWD:$(pwd)"

dynaconf list

@jctanner
Handle all failures when pwd does not exist.
23f7b23 
Signed-off-by: James Tanner <tanner.jc@gmail.com>
@netlify
Copy link

netlify bot commented Jan 31, 2023 •
edited
Loading

✅ Deploy Preview for dynaconf ready!

Name Link
🔨 Latest commit 00e1b60
🔍 Latest deploy log https://app.netlify.com/sites/dynaconf/deploys/63d94af398059b00086e226f
😎 Deploy Preview https://deploy-preview-857--dynaconf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jctanner
Do not write to .env if dotenv wasn't imported.
6712be9 
Signed-off-by: James Tanner <tanner.jc@gmail.com>
@jctanner
Add functional test & allow test listing or filtering.
5d9a9f2 
Signed-off-by: James Tanner <tanner.jc@gmail.com>
@jctanner
Make functional test pass.
f5d84f5 
Signed-off-by: James Tanner <tanner.jc@gmail.com>
@jctanner
Fix flake8 url to github.
6b3d31e 
Signed-off-by: James Tanner <tanner.jc@gmail.com>
@jctanner
Fix lint problems.
c34eb9c 
Signed-off-by: James Tanner <tanner.jc@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #857 (c34eb9c) into master (243f4f7) will decrease coverage by 0.62%.
The diff coverage is 60.71%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##            master     #857      +/-   ##
===========================================
- Coverage   100.00%   99.38%   -0.62%     
===========================================
  Files           21       21              
  Lines         1779     1802      +23     
===========================================
+ Hits          1779     1791      +12     
- Misses           0       11      +11
Impacted Files Coverage Δ
dynaconf/loaders/env_loader.py 90.00% <50.00%> (-10.00%) ⬇️
dynaconf/utils/files.py 95.91% <50.00%> (-4.09%) ⬇️
dynaconf/cli.py 98.47% <60.00%> (-1.53%) ⬇️
dynaconf/base.py 100.00% <100.00%> (ø)
dynaconf/utils/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jctanner
Skip missing_pwd test on windows.
00e1b60 
Signed-off-by: James Tanner <tanner.jc@gmail.com>
@rochacbruno rochacbruno merged commit 1625712 into dynaconf:master Jan 31, 2023
@rochacbruno rochacbruno added this to the 3.1.12 milestone Feb 2, 2023
rochacbruno added a commit that referenced this pull request Mar 2, 2023
@rochacbruno
Release version 3.1.12
2fab499 
Shortlog of commits since last release:

    André "decko" de Brito (2):
          Removes Codacy Coverage Reporter (#871)
          Add a namespace property for VAULT_FOR_DYNACONF dict (#870)

    Bruno Rocha (8):
          Release version 3.1.11
          bump dev version to 3.1.12
          Ensure `dynaconf get` returns a valid json string. (#813)
          [bugfix] Fix access of keys with spaces (#815)
          hotfix func tests (#816)
          Add Python 3.11 to CI (#830)
          fix lint error
          Fix casting on Validator and improve docs (#873)

    Bryan Weber (1):
          Fix typos in envvars docs (#840)

    Florian Apolloner (1):
          Small typo fix. (#822)

    Maxwell G (1):
          Include license files for vendored deps (#841)

    MicLon (1):
          fix: envvars.md get `HOME` environment variable (#831)

    Otávio Dantas (1):
          doc(pt-br): translate flask extension to pt-br (#852)

    Sergio Kef (1):
          Fix code snippet in docs (#843)

    Tetiana (1):
          #817 Add note about defining root_path when testing (#818)

    jctanner (1):
          Handle all failures when pwd does not exist. (#857)

    jmeichle (1):
          Add support for VAULT_NAMESPACE_FOR_DYNACONF (#854)
@decko decko mentioned this pull request Mar 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rochacbruno rochacbruno rochacbruno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.12
Development

Successfully merging this pull request may close these issues.

[bug] Dynaconf fails with FileNotFoundError when current working directory doesn't exists
3 participants
@jctanner @codecov-commenter @rochacbruno