Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix mkdocs warnings for cleaner build output #1061

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

mitches-got-glitches
Copy link
Contributor

@mitches-got-glitches mitches-got-glitches commented Feb 26, 2024

Working on a recent PR, the output from mkdocs build and mkdocs serve was very noisy because of warnings. This PR fixes them all to make the build clean. There were many like the first screenshot.
image
image
image

Result

image

Much cleaner, only a few warnings around the Portuguese language docs which I wasn't sure how to deal with.

Other comments

  • My IDE automatically deleted some trailing whitespace from the markdown files on save
  • I'm not sure if the previous version of the references was actually useful within the Portuguese docs? Can you advise how these are currently in use?

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for dynaconf ready!

Name Link
🔨 Latest commit a8ae36f
🔍 Latest deploy log https://app.netlify.com/sites/dynaconf/deploys/65dd104bcf61e40008cc8367
😎 Deploy Preview https://deploy-preview-1061--dynaconf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pedro-psb pedro-psb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the contribs.

I was unsure about prebuild_index, but it looks like its not supported for some time in mkdocs-material.

@pedro-psb pedro-psb merged commit 09a043f into dynaconf:master Feb 26, 2024
1 check passed
@pedro-psb
Copy link
Member

I'm not sure if the previous version of the references was actually useful within the Portuguese docs? Can you advise how these are currently in use?

These files are not currently being used. They were suppose to prepare for a translated build, which was discussed in #797 and was being developed in #826.

pedro-psb added a commit that referenced this pull request Mar 18, 2024
Shortlog of commits since last release:

    Aaron DeVore (1):
          docs: fix incorrect combination of TOML table and inline table (#1070)

    Adam Kjems (1):
          doc: replace dead link to flask subclassing page (#1031)

    Bruno Rocha (2):
          feat: Add `@get` converter to alias existing keys (#1040)
          fix: dependabot alert 21 about Django (on tests) (#1067)

    HAMASHITA (1):
          chore: Fix misspelled variable name (#1032)

    Lucas Limeira (1):
          doc: Add explicit Dynaconf instantiation to sample code (#1022)

    Mitchell Edmunds (5):
          docs: Add dynaconf API to docs with mkdocstrings (#1058)
          docs: Fix mkdocs warnings for cleaner build output (#1061)
          chore: add "typos" tool and run it in codebase/docs (#1063)
          Fix referencing issues in the docs (#1062)
          chore(ci): Replace lint and formatting tools with ruff (#1074)

    Mostafa Alayesh (1):
          doc: fix argument `env` in Validation at validation.md (#1051)

    Pedro Brochado (11):
          chore(ci): Fix misspelled GitHub action names on main.yml (#1033)
          chore(ci): move release workflow to GitHub actions (partial) (#1043)
          chore(ci): fix shell script in release.yml
          chore(ci): fix shell script in release.yml (2)
          chore(ci): fix create-release-commit.sh permission
          fix: include load with relative root path (#1049)
          fix: `_bypass_evaluation` showing in end-user settings (#1071)
          chore: Replace/Update release script (#1078)
          docs: fix wrong info about validation trigger on insantiation (#1076)
          misc: fix bump-my-version invalid config and rename bump msg
          misc: fix changelog generation order

    Shanshi Shi (1):
          Fix a typo in the docs about `merge_enabled` setting (#1044)

    Sun Jianjiao (1):
          doc: Fix the syntax errors in the sample program. (#1027)

    tdzz1102 (1):
          [Doc] Fix a small mistake of .env file in the document (#1036)

    xiaohuanshu (1):
          doc: fix click help syntax error (#1041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants