Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace chalk with cli-color #83

Closed
nelsonic opened this issue Jan 18, 2024 · 1 comment · Fixed by #84
Closed

Replace chalk with cli-color #83

nelsonic opened this issue Jan 18, 2024 · 1 comment · Fixed by #84
Labels
chore a tedious but necessary task often paying technical debt T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule.

Comments

@nelsonic
Copy link
Member

As noted in #73 chalk has made a Unnecessary Breaking Change!

"require() of ES modules is not supported"

So I propose replacing:

terminate/test/test.js

Lines 2 to 3 in 24c0f43

var chalk = require('chalk');
var red = chalk.red, green = chalk.green, cyan = chalk.cyan;

with:

var clc = require("cli-color");
var red = clc.redBright, green = clc.greenBright, cyan = clc.cyanBright;

This will avoid future @dependabot PRs failing.
@nelsonic nelsonic added chore a tedious but necessary task often paying technical debt T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. labels Jan 18, 2024
nelsonic added a commit that referenced this issue Jan 18, 2024
@nelsonic
replace chalk with cli-color #83
1e431bb
@nelsonic nelsonic mentioned this issue Jan 18, 2024
Merged
@nelsonic
Copy link
Member Author

PR: #84

@nelsonic nelsonic mentioned this issue Jan 18, 2024
Closed
nelsonic added a commit that referenced this issue Jan 18, 2024
@nelsonic
fully remove chalk #83
4b25750
@asntc asntc closed this as completed in #84 Jan 18, 2024
asntc added a commit that referenced this issue Jan 18, 2024
@asntc
Merge pull request #84 from dwyl/replace-chalk-with-cli-color-#83
ce6475e 
PR: Replace `chalk` with `cli-color` #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore a tedious but necessary task often paying technical debt T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PR: Replace chalk with cli-color #83 dwyl/terminate
1 participant
@nelsonic