Build container with arguments #19
Conversation
Allow container to take build args so that we can select the versions of Terraform and Ruby - Base the container off Ruby rather than the Terraform image so that we have all the tools we need - Upgrade the default Ruby version to the latest stable (3.1.2) - bundle exec the kitchen binary in the entrypoint now that we're bundle installing the Ruby Gems - Add a default source to the Gemfile, not doing so was deprecated in a recent bundler version - Add a Gemfile.lock so that we are able to lock the Gems Signed-off-by: Dan Webb <dan.webb@damacus.io>
This command is only available to be run as root and we are running as kitchen for security reasons Signed-off-by: Dan Webb <dan.webb@damacus.io>
|
@dan-hill2802 if we want to run |
thinking about it, we can probably just change the user to |
This will allow users to more easily select the Terraform version Signed-off-by: Dan Webb <dan.webb@damacus.io>
- Stop using -l so that we get the environment loaded. This allows us to find the bundler binstubs - Stop using bundle exec as we're now using binstubs. - Install the Gems to a system location and install the binstubs, so that we don't need a Gemfile to run Kitchen Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
damacus
force-pushed
the
build-container
branch
10 times, most recently
from
18d1090 to
1168a30
Compare
Signed-off-by: Dan Webb <dan.webb@damacus.io>
|
@dan-hill2802 this is ready to review again. I'm going to see if I can tidy up anything before merging this afternoon 📦 |
Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
|
@dan-hill2802 this is good to go now. I've added the KICS scan to the new workflow so, I'm fairly sure we can drop the old workflow now. |
Fix building first stage without arguments Signed-off-by: Dan Webb <dan.webb@damacus.io>
Ignore apt version pinning Signed-off-by: Dan Webb <dan.webb@damacus.io>
this support newer versions of Terraform Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
Signed-off-by: Dan Webb <dan.webb@damacus.io>
|
Kudos, SonarCloud Quality Gate passed!
|
|
@dan-hill2802 this workflow will fail until an internal contributor runs it because the workflow doesn't have the correct permissions to create/push the artefact right now. |
I'm going to merge and raise a new PR to confirm the new workflow. Releases are not automatic on this repo and the Quay builds have been disabled. |
|
These images will all push with -edge right now. And I think that'll be fine. We should do a follow-up PR for a workflow that's triggered by a release. |
Allow container to take build args so that we can select the versions of Terraform and Ruby
Signed-off-by: Dan Webb dan.webb@damacus.io